Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Openshift container changes #340

Merged
merged 5 commits into from
Mar 6, 2024
Merged

feat: Openshift container changes #340

merged 5 commits into from
Mar 6, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Mar 6, 2024

Description

Ensures the Node-RED stack containers will allow for npm install on OpenShift

Also adds some resource constraints to the db upgrade job container. (Still need to test the upgrade on OpenShift)

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from ppawlowski March 6, 2024 13:17
@hardillb hardillb self-assigned this Mar 6, 2024
@hardillb hardillb changed the title Openshift changes feat: Openshift container changes Mar 6, 2024
@hardillb
Copy link
Contributor Author

hardillb commented Mar 6, 2024

OK, I know why Node-RED 2.2.x container failed. I'm going to say that 2.2 is not supported on OpenShift (we will drop it when 4.0 ships anyway)

@hardillb
Copy link
Contributor Author

hardillb commented Mar 6, 2024

@ppawlowski Can you look why the test failed? I can see in the logs that the file-server failed because the ff-context db can't be found. But I can't find the logs for the upgrade job running in the output to see why it failed to create the db

@hardillb
Copy link
Contributor Author

hardillb commented Mar 6, 2024

@ppawlowski Thanks, I should have tried updating the base branch

@ppawlowski
Copy link
Contributor

For unknown reasons, there are no job logs in the chart testing output. At least I was not able to find it.
In general, this output is quite noisy and sometimes hard to find the root cause...

@hardillb hardillb merged commit 3726e30 into main Mar 6, 2024
33 checks passed
@hardillb hardillb deleted the openshift-changes branch March 6, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants