Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removal of redundant service used for communication with database #323

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Feb 20, 2024

Description

This pull request includes the following changes:

  • Add database host helper function
  • Update database host in main application configmap and file-server job script
  • Move file-storage config map to separate file
  • Adjust forge and file-storage deployments to restart if config maps have changes
  • Remove ExternalName service used for communication with the database, both

Related Issue(s)

#143

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb
Copy link
Contributor

@ppawlowski Can you resolve the conflict on this please and I'll have a look

@hardillb hardillb merged commit 3f486ff into main Feb 22, 2024
6 checks passed
@hardillb hardillb deleted the feat-external-name-service branch February 22, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants