Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add containerSecurityContext for each container #289

Merged
merged 3 commits into from
Jan 31, 2024
Merged

feat: Add containerSecurityContext for each container #289

merged 3 commits into from
Jan 31, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This PR adds the possibility to configure containerSecurityContext for each container created by our helm chart.

Related Issue(s)

#288

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

node-red:3.1.x-main-linux-amd64 scan results

3 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

node-red:3.0.2-main-linux-amd64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
4 tests ±0  0 ✅ ±0  0 💤 ±0  4 ❌ ±0 
5 runs  ±0  0 ✅ ±0  0 💤 ±0  5 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

node-red:2.2.3-main-linux-amd64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

node-red:3.0.2-main-linux-arm64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
4 tests ±0  0 ✅ ±0  0 💤 ±0  4 ❌ ±0 
5 runs  ±0  0 ✅ ±0  0 💤 ±0  5 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

file-server:main-linux-amd64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

forge-k8s:main-linux-amd64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

node-red:2.2.3-main-linux-arm64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

node-red:3.1.x-main-linux-arm64 scan results

3 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

file-server:main-linux-arm64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

forge-k8s:main-linux-arm64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0641700. ± Comparison against base commit e2cc6dc.

♻️ This comment has been updated with latest results.

@hardillb
Copy link
Contributor

Are we missing a entry in the values.yml for the file-store?

hardillb
hardillb reviewed Jan 30, 2024
View reviewed changes
helm/flowforge/templates/file-storage.yml Outdated
securityContext:
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
securityContext: {{- toYaml .Values.forge.broker.containerSecurityContext | nindent 10 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is using the broker settings

Suggested change
securityContext: {{- toYaml .Values.forge.broker.containerSecurityContext | nindent 10 }}
securityContext: {{- toYaml .Values.forge.fileStore.containerSecurityContext | nindent 10 }}

hardillb
hardillb requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted 2 things

@hardillb hardillb merged commit d0321eb into main Jan 31, 2024
37 checks passed
@hardillb hardillb deleted the feat-container-security-context branch January 31, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppawlowski @hardillb