-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuring sentry telemetry #188
Conversation
test/customizations.yml
Outdated
@@ -43,6 +43,10 @@ forge: | |||
posthog: | |||
capture_pageview: false | |||
apikey: phc_fdlksajfdfadfsafsaf | |||
sentry: | |||
production_mode: false | |||
frontend_dsn: https://sentry.io/flowforge/flowforge-frontend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just pure test data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I've pushed fixes to the tests, I'll ask @ppawlowski to also review
@@ -129,7 +129,7 @@ data: | |||
http: info | |||
telemetry: | |||
enabled: {{ .Values.forge.telemetry.enabled }} | |||
{{ if or (.Values.forge.telemetry.plausible) (.Values.forge.telemetry.posthog) }} | |||
{{ if or (.Values.forge.telemetry.plausible) (.Values.forge.telemetry.posthog) (hasKey .Values.forge.telemetry.sentry "frontend_dsn") }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check if or
can apply to more than 2 values
Co-authored-by: Ben Hardill <[email protected]>
Description
For FlowFuse/flowfuse#2862
FlowFuse expects config file in below format:
Related Issue(s)
FlowFuse/flowfuse#2862
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label