Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert create-pod Role name #159

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Revert create-pod Role name #159

merged 1 commit into from
Aug 1, 2023

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Aug 1, 2023

@elenaviter I've had to revert the renaming of the ClusterRole because it breaks upgrades.

We can look at this again after the release this week

Description

We can not change the name of an already created ClusterRole as it breaks upgrades.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@elenaviter I've had to revert the renaming of the ClusterRole because it breaks upgrades.

We can look at this again after the release this week
@hardillb hardillb added this to the 1.10 milestone Aug 1, 2023
@hardillb hardillb self-assigned this Aug 1, 2023
@hardillb hardillb merged commit 28a146b into main Aug 1, 2023
1 check passed
@hardillb hardillb deleted the hardillb-patch-1 branch August 1, 2023 11:49
@elenaviter
Copy link
Contributor

Hi @hardillb,

Thank you for bringing this to my attention. I understand you're busy with the release.
When time allows, I'd be grateful for any follow-up you can provide regarding this aspect.
Thank you once again for your time and support!

@hardillb
Copy link
Contributor Author

@elenaviter can you raise an issue with detail of what exactly you were trying to achieve with this change then we have somewhere to discuss options going forward.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants