Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade job needs to make use of pq username from secret not assume "forge" #305

Open
hardillb opened this issue Feb 10, 2024 · 0 comments
Assignees
Labels
needs-triage Needs looking at to decide what to do

Comments

@hardillb
Copy link
Contributor

Current Behavior

Upgrade job runs the following SQL

    #!/bin/sh
    apk add --no-cache postgresql14-client
    psql -v ON_ERROR_STOP=1 -h {{ .Release.Name }}-postgresql -U postgres postgres <<-ESQL
    SELECT datname FROM pg_database WHERE datistemplate = false;
    SELECT 'CREATE DATABASE "ff-context"' WHERE NOT EXISTS (SELECT FROM pg_database WHERE datname = 'ff-context')\gexec
    GRANT ALL PRIVILEGES ON DATABASE "ff-context" TO "forge";
    ESQL

Expected Behavior

  • We should allow context db name to be passed in as argument to the helm chart
  • We should pick up the username for the context db from the pg secret

Steps To Reproduce

Install helm chart.

Environment

  • FlowFuse version: 2.0.0
  • Node.js version: 18
  • npm version: 9
  • Platform/OS: K8S
  • Browser: NA
@hardillb hardillb added the needs-triage Needs looking at to decide what to do label Feb 10, 2024
@ppawlowski ppawlowski self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs looking at to decide what to do
Projects
Status: Todo
Development

No branches or pull requests

2 participants