Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instance log passthrough support #3448

Closed
wants to merge 1 commit into from
Closed

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Feb 5, 2024

part of #3324

Description

Allow nr-launcher to print Node-RED logs (in JSON format) to stdout. This allows it to be ingested by log services on docker/k8s

Related Issue(s)

#3324

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 2.1 milestone Feb 5, 2024
@hardillb hardillb self-assigned this Feb 5, 2024
@hardillb
Copy link
Contributor Author

hardillb commented Feb 5, 2024

Pairs with FlowFuse/nr-launcher#207

@knolleary
Copy link
Member

My concern is what a FF Cloud user will think this option does - as it will do nothing for them. And there needs to be some documentation somewhere on what this feature does.

Does this really need to be on a per-instance basis or can it be an option set via the yml file?

@hardillb
Copy link
Contributor Author

hardillb commented Feb 5, 2024

It could be done as a env var injected into the container by the driver. I'll give it a rework

@hardillb hardillb marked this pull request as draft February 5, 2024 17:28
@hardillb
Copy link
Contributor Author

hardillb commented Feb 6, 2024

@hardillb hardillb closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants