Revert "Fix Window Positioning with Multiple Montiors"

[onesounds]

Reverts #2756

[coderabbitai]

Walkthrough

Walkthrough

The recent updates enhance the window positioning and resizing logic by replacing consolidated properties with separate ones for WindowLeft and WindowTop. Additionally, various methods related to UI, event handling, and window animation in MainWindow.xaml.cs and SettingWindow.xaml.cs have been refactored for clarity and performance. These changes improve the overall user experience and code maintainability.

Changes

File/Path	Change Summary
Flow.Launcher.Infrastructure/.../Settings.cs	Replaced WindowPosition, PreviousScreen, and PreviousDpi with WindowLeft and WindowTop properties.
Flow.Launcher/MainWindow.xaml.cs	Restructured DispatcherTimer initialization, refactored multiple methods related to window resizing, positioning, and UI.
Flow.Launcher/SettingWindow.xaml.cs	Simplified window positioning logic by directly assigning to Top and Left properties and refactoring helper methods.
Flow.Launcher/ViewModel/MainViewModel.cs	Updated IncreaseWidth and DecreaseWidth methods to use WindowLeft instead of WindowPosition and adjusted logic.

Poem

In Flow Launcher's dance of code,
Windows move to a new abode.
Left and Top now lead the way,
Polished UI, a brighter day.
Rabbit hops in joy and mirth,
For settings refined and smoother worth.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

🥷 Code experts: Yusyuriv

onesounds, Yusyuriv have most 👩‍💻 activity in the files.
onesounds, Yusyuriv have most 🧠 knowledge in the files.

See details

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

Activity based on git-commit:

	onesounds	Yusyuriv
JUL
JUN	4 additions & 0 deletions
MAY	24 additions & 6 deletions	6 additions & 22 deletions
APR	12 additions & 2 deletions	126 additions & 49 deletions
MAR
FEB

Knowledge based on git-blame:
onesounds: 25%
Yusyuriv: 14%

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	onesounds	Yusyuriv
JUL
JUN	278 additions & 204 deletions
MAY	128 additions & 21 deletions	12 additions & 22 deletions
APR	37 additions & 22 deletions
MAR
FEB

Knowledge based on git-blame:
onesounds: 37%
Yusyuriv: 1%

Flow.Launcher/SettingWindow.xaml.cs

Activity based on git-commit:

	onesounds	Yusyuriv
JUL
JUN	28 additions & 6 deletions
MAY	9 additions & 9 deletions	132 additions & 501 deletions
APR	115 additions & 91 deletions	22 additions & 43 deletions
MAR
FEB

Knowledge based on git-blame:
Yusyuriv: 63%
onesounds: 26%

Flow.Launcher/ViewModel/MainViewModel.cs

Activity based on git-commit:

	onesounds	Yusyuriv
JUL
JUN		16 additions & 1 deletions
MAY	115 additions & 28 deletions	23 additions & 12 deletions
APR	70 additions & 4 deletions
MAR
FEB

Knowledge based on git-blame:
onesounds: 12%
Yusyuriv: 2%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

This PR is 25.954198473282442% new code.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[jjw24]

@onesounds just so it's recorded here, what was the issue that we had to revert?

Also does this fix the remember last position issue?

[onesounds]

• Fixed BUG: (Search Window Position: Remember Last Position) option is not working properly #2820
• Confirmed that it was fixed successfully.

I tested my PR, but merged it without testing Taoo's fix. This is both Taoo's and my fault for not testing thoroughly. I checked Taoo's commit, but nothing seemed particularly wrong and I couldn't figure out why. I chose to revert because the PR was changed based on Point2D and I can't fix it, and I don't want to ask taoo to fix it.

[onesounds]

After this, the #2320 issue is reinstated. This is a simple issue and will be worked on in a separate PR.

[jjw24]

OK so issue 2820 is fixed, but 2320 is not, shall we reopen issue 2320?

[VictoriousRaptor]

Just FYI microsoft/PowerToys#33784 this might be related. Looks like they just simply set the position twice.