-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Progressbar Dispatcher Exception #1445
base: dev
Are you sure you want to change the base?
Conversation
Will this make the progressbar always run in the background? people has complaint about the tiny little cpu usage because of that before. |
I only changed the storyboard binding. so it doesn't matter. |
basically discussion here #295. (Although I think it is a very trivial cost to have it always animate) |
Sorry I just saw that you use trigger to control the animation. That's a much better solution. Thank you so much. |
@taooceros have you reviewed this and good to merge? |
sorry I thought I already merged... |
…gressBarDispatcher
I just give a similar test for that. There's tiny little cpu usage when flow is hide in this pr compared to the current dev branch (only <.5%). |
Hmm, what steps did you do to test it, let me give it a test. |
Also @Sparrkle @taooceros how do I reproduce this error consistently? |
@Sparrkle I add stopStoryBoard when exit the trigger. Could you please take a look on whether I am doing it correctly? |
@taooceros @Sparrkle is this PR still required? Still getting that error? |
It's a better implementation so let's get it in anyway. Though we may need to resolve the conflict |
Removed Dispatcher and change how it works storyboard.
What's the PR