docs: be more precise in flex-model field descriptions for StorageScheduler #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Höning <[email protected]>
victorgarcia98
approved these changes
Jul 4, 2024
Flix6x
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Sorry for the late review. Behind the scenes we were still discussing a lot in the context of relaxing power and soc constraints, which this touched. This suggests we intend to keep treating the soc-min and soc-max as hard constraints, and will switch the others to penalized limits.
This is correct, right, @victorgarcia98 ?
| * - ``soc-gain`` | ||
| - ``.1kWh`` | ||
| - Encode SoC gain per time step. A constant gain every time step, or see [#sensor_field]_. | ||
| - Encode SoC gain per time step. Useful if energy is created by an external process (in-flow). Denotes a constant gain every time step, or see [#sensor_field]_. |
Yes, indeed. soc max and soc min should be always hard and we relaxed the targets and maxima and minima. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More clarity on some flex-model field descriptions, the idea came up when someone on the mailing list used
soc-minand thensoc-at-startbelow that, which is as of now infeasible for our storage scheduler.I'm not quite happy with this PR yet, either.
Apparently, we are very hard on the
soc-minandsoc-maxvalues, while we are (planning to be) softer onsoc-minima,soc-maximaandsoc-targets. I notice that the terms "min"/"minima" and "max"/"maxima" don't give that impression.Example from a user perspective: If I prefer my EV battery to not be charged below 20%, I set that as
soc-min. My intention is not that I bring the EV back to the charger at 10% and no schedule will be made until I bring it back up to 20%.