Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerbal can die if his original part gets destroyed #399

Open
numberlesstim opened this issue Mar 2, 2024 · 1 comment
Open

Kerbal can die if his original part gets destroyed #399

numberlesstim opened this issue Mar 2, 2024 · 1 comment
Labels
C# Requires code enhancement New feature or request
Milestone

Comments

@numberlesstim
Copy link

Repro:

  1. Build or load the below craft and spawn it with 1 Kerbal each in the Cockpit and the second CrewCabin
  2. Move the Kerbal from the Cockpit to the InlinePort seat.
  3. Move the other Kerbal to the Cockpit seat
  4. Stage to destroy the second Kerbals original part
  5. Observe the Kerbal die at the same time the part does despite empty seats being available

Craft
Craftfile: InlinePort1.zip

@JonnyOThan
Copy link
Collaborator

Hijacking this issue for a more generic pass:

Currently, unbuckling is conceptually similar to opening the crew transfer dialog window. You're still in your old seat until you move to a new one. Even so, some seats like the inline docking ports are "fake" - the part doesn't have crew capacity so you still actually are assigned to whatever part you came from. That can lead to strange results when parts are decoupled or destroyed.

In general, if the part you are actually assigned to gets decoupled or destroyed, then we should find an empty seat close to where you are now and assign you there. If that's not possible, we could remove the kerbal from the old vessel and let them roam around in the current one, but they'd have to go EVA at some point. Or see if the game will work with overfilling a crewed part.

@JonnyOThan JonnyOThan added enhancement New feature or request C# Requires code labels Mar 2, 2024
@JonnyOThan JonnyOThan added this to the 1.0.0 milestone Mar 2, 2024
@JonnyOThan JonnyOThan modified the milestones: 1.0.0, 0.2.19 Mar 31, 2024
@JonnyOThan JonnyOThan modified the milestones: 0.2.19, 0.2.20 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Requires code enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants