New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow `_count=0` in search parameter parsing routine. #2686

Closed

ewoutkramer opened this issue Jan 29, 2024 · 0 comments · Fixed by #2687

Member

ewoutkramer commented Jan 29, 2024

From https://chat.fhir.org/#narrow/stream/179171-dotnet/topic/Firely.20SearchParams.20Bug.3F:

Tried using the SearchParams.FromUriParamList(xxx); call and it's returning an error in our unit tests.
Spec says _count=0 (https://build.fhir.org/search.html#_count) is valid, but looks like firely won't allow it?
https://github.com/FirelyTeam/firely-net-sdk/blob/develop/src/Hl7.Fhir.Base/Rest/SearchParams.cs#L117 (should be count<0 not count<=0?)

And Corky writes:

Spec seems pretty clear that the client should be able to provide a parameter of _count=0 and the receiving server would then interpret it as _summary=count. You can get around it for now in your own code by setting _summary but I would think that Firely should handle this correctly and allow for _count=0.

So we should change that line of code. Seems like something we can do while listening in to the WGM ;-)

ewoutkramer added the bug label

ewoutkramer mentioned this issue

The _count parameter should allow '0' as a value #2687

Merged

mmsmits closed this as completed in #2687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment