Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate lack of plans to add SafetyNet support #87

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Sep 25, 2024

Google has deprecated SafetyNet attestation format. Since this library already does not offer support for verifying it, this clarifies that there are now no plans to do so.

android-key support should still get added, and the verification procedure is quite a bit more straightforward, though I've still yet to track down a test vector or obtain a device that produces this format.

https://android-developers.googleblog.com/2024/09/attestation-format-change-for-android-fido2-api.html

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (1c7b416) to head (80bc7cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #87   +/-   ##
=========================================
  Coverage     81.36%   81.36%           
  Complexity      308      308           
=========================================
  Files            33       33           
  Lines           982      982           
=========================================
  Hits            799      799           
  Misses          183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed merged commit d324c80 into main Sep 25, 2024
14 checks passed
@Firehed Firehed deleted the safetynet-deprecation branch September 25, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant