Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional registration support #85

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conditional registration support #85

merged 4 commits into from
Jul 9, 2024

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Jul 9, 2024

This adds a new optional parameter to the credential registration verification procedure (WebAuthn 7.1) to account for conditional mediation.

Verify that the UP bit of the flags in authData is set, unless options.mediation is set to conditional.

Note that this is only in the draft spec, but it's likely to remain materially unchanged since this exact tooling was described at WWDC24. Still, I'm going to leave this undocumented for now (besides the actual method signature) in case anything changes before the next published version.

Fixes #83.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (dc5e32a) to head (58d465a).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
+ Coverage     81.26%   81.36%   +0.10%     
- Complexity      307      308       +1     
============================================
  Files            33       33              
  Lines           982      982              
============================================
+ Hits            798      799       +1     
+ Misses          184      183       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed merged commit 3e88b04 into main Jul 9, 2024
14 checks passed
@Firehed Firehed deleted the conditional-registration branch July 9, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for conditional mediation in credential creation
1 participant