Add limited support for RS256 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
============================================
+ Coverage 78.51% 81.30% +2.78%
- Complexity 304 307 +3
============================================
Files 32 33 +1
Lines 954 984 +30
============================================
+ Hits 749 800 +51
+ Misses 205 184 -21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for RSA COSE key parsing and subsequent reformatting to PEM. For the most part, everything downstream Just Works since it implements the same
PublicKeyInterfaceasEllipticCurveIn theory, this should work in all (legal) assertion paths. I'm less sure about attestation, so I'm indicating only partial support in the README. As the remaining attestation formats get supported, this should become extremely clear. Most formats don't really look at the public key in favor of the bundled certificate chain.