Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual concatenation with actual ASN.1 encoder #78

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Mar 10, 2024

While on its own the current implementation is perfectly stable due to fixed lengths, adding support for other formats will become highly problematic. Instead, replace the ASN.1 handling with a suitable library.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (ef12eb8) to head (49006e6).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #78      +/-   ##
============================================
+ Coverage     78.01%   78.51%   +0.50%     
  Complexity      304      304              
============================================
  Files            32       32              
  Lines           955      954       -1     
============================================
+ Hits            745      749       +4     
+ Misses          210      205       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed merged commit 69fdcd3 into main Mar 10, 2024
14 checks passed
@Firehed Firehed deleted the real-asn1 branch March 10, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant