Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support for packed format #58

Merged
merged 15 commits into from
Nov 27, 2023
Merged

Add partial support for packed format #58

merged 15 commits into from
Nov 27, 2023

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Nov 26, 2023

Adds partial support for packed attestation - only the self-attested format. This is used by, at least, macOS Edge when not signed in.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (652d9f1) 82.29% compared to head (ffdfea0) 82.90%.

Files Patch % Lines
src/Attestations/Packed.php 80.76% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #58      +/-   ##
============================================
+ Coverage     82.29%   82.90%   +0.61%     
- Complexity      227      233       +6     
============================================
  Files            26       27       +1     
  Lines           672      702      +30     
============================================
+ Hits            553      582      +29     
- Misses          119      120       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed marked this pull request as ready for review November 27, 2023 17:26
@Firehed Firehed merged commit d76ab54 into main Nov 27, 2023
10 checks passed
@Firehed Firehed deleted the packed branch November 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant