Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User handle support #31

Merged
merged 13 commits into from
Nov 10, 2023
Merged

User handle support #31

merged 13 commits into from
Nov 10, 2023

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Aug 28, 2023

Start to make use of the userHandle field in the API wire formats. This assists in implementing §7.2 step 6 where the user was not identified prior to the authentication ceremony beginning.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b98441a) 79.03% compared to head (017e2db) 79.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #31      +/-   ##
============================================
+ Coverage     79.03%   79.22%   +0.19%     
- Complexity      164      168       +4     
============================================
  Files            24       24              
  Lines           539      544       +5     
============================================
+ Hits            426      431       +5     
  Misses          113      113              
Files Coverage Δ
src/GetResponse.php 94.91% <100.00%> (+0.17%) ⬆️
src/ResponseParser.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Firehed Firehed marked this pull request as ready for review November 10, 2023 19:52
@Firehed Firehed merged commit a8bc624 into main Nov 10, 2023
10 checks passed
@Firehed Firehed deleted the user-handle branch November 10, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant