Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Disable auto-commenting to PR for matrix jobs #356

Closed
weilinzung opened this issue Mar 25, 2024 · 1 comment
Closed

[ENHANCEMENT] Disable auto-commenting to PR for matrix jobs #356

weilinzung opened this issue Mar 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@weilinzung
Copy link
Contributor

The use case you're trying to solve

When using this action for matrix jobs, it will post multiple PR comments. Like 10x deploy matrix jobs, it will post 10x of PR comments.

Change to the action that would solve that use case

  • Add new input to disable auto-commenting
  • Add deployed metadata to the action output, like the preview URL and expired date

Other considerations

Once we can disable the auto-commenting and have the outputs(metadata), we would like to post the comment once with all the deploy preview channel links.

@weilinzung weilinzung added the enhancement New feature or request label Mar 25, 2024
@jhuleatt
Copy link
Collaborator

Fixed in #371

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants