Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 16 actions are deprecated #341

Closed
rohit231095 opened this issue Jan 31, 2024 · 16 comments · Fixed by #343
Closed

Node.js 16 actions are deprecated #341

rohit231095 opened this issue Jan 31, 2024 · 16 comments · Fixed by #343

Comments

@rohit231095
Copy link

I am seeing this below warning in my project's GitHub actions repeatedly. This Firebase deployment action needs an upgrade to Node.js 18 or 20 as version 16 actions are deprecated.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: FirebaseExtended/action-hosting-deploy@v0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Please upgrade this action as soon as possible.

@MNITD
Copy link

MNITD commented Jan 31, 2024

@rohit231095 do you have only the warning in the console or the action is broken as well?

@rohit231095
Copy link
Author

@MNITD I can see only a warning like the image below. The action is still working, and deployment is not broken.

image

Reporting it to prevent any incoming breaking possibilities later on.

@oyvindwe
Copy link

oyvindwe commented Feb 2, 2024

I have already submitted PR #340 to address this.

Would be good if some of the maintainers could follow up before Node 16 is sunset!

@oyvindwe
Copy link

oyvindwe commented Feb 9, 2024

Actions are now failing:

That is most likely some other problem with your job. Sunset date for node 16 has not yet been communicated.

@annoyingmouse
Copy link

Actions are now failing:

That is most likely some other problem with your job. Sunset date for node 16 has not yet been communicated.

You are right - please accept my apologies!

@filfreire
Copy link

FYI, while maintainers don't merge @oyvindwe's PR #340 that fixes this warning, you can edit your action usage to point to the PR's commit directly:

-FirebaseExtended/action-hosting-deploy@v0
+FirebaseExtended/action-hosting-deploy@79b1a830a9ae85409cb38056dd7761f6f1cb83fd

@johnnyoshika
Copy link

johnnyoshika commented Mar 8, 2024

This workaround to set a node version doesn't work:

      - uses: actions/setup-node@v4
        with:
          node-version: '18'

When using FirebaseExtended/action-hosting-deploy@v0 I still get this warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: FirebaseExtended/action-hosting-deploy@v0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@steve-scorn
Copy link

This appears to have now been enforced, making this action no longer usable.

The only way I could get it to work was by using @filfreire 's solution above. Is it possible to get PR #340 merged?

@oyvindwe
Copy link

oyvindwe commented Mar 8, 2024

@johnnyoshika

This workaround to set a node version doesn't work:

This is to set the node version your build uses, not the version used by the action itself.

@steve-scorn:

This appears to have now been enforced, making this action no longer usable.

For now, you can work around this issue by setting the environment variabel ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true, but that will stop working May 13. See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

@testak-m
Copy link

testak-m commented Mar 9, 2024

I asked if it would be possible to release #344 since it would be resolved once it was released.
#344 (comment)

@jhonnycgarcia
Copy link

The error is still occurring.
image

@oyvindwe
Copy link

oyvindwe commented Apr 5, 2024

The error is still occurring.

It will occur until a fix is merged and released.

Workaround is described here: #341 (comment)

@oyvindwe
Copy link

Fixed by #344

This issue can be closed. Can we please get a release?

@memark
Copy link

memark commented Apr 29, 2024

@wayzie-jm AFAICT the fix has only been merged, not released.

@wayzie-jm
Copy link

@wayzie-jm AFAICT the fix has only been merged, not released.

Rookie mistake. Thanks.

@Danish-Dsouza
Copy link

What does one have to do to get a release around here?

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.