Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.2] Transparency for tools/weapons not rendered correctly over the tranclucent background #386

Closed
vgrynch opened this issue Sep 24, 2024 · 6 comments

Comments

@vgrynch
Copy link

vgrynch commented Sep 24, 2024

Bug Description

Transparency for semi-transparent (translucent) tools/weapons not rendered correctly over the water.
I have tried various options with no help at all, in particular, the most relevant options too:

  • Fabulous graphics (not supported by Alex's mobs for a pick axe, Epic Fight weapons still hide water)
  • Animate only visible textures (no effect when enabling/disabling)
  • Translucent face sorting (disabling it has no effect)
  • Shader (ComplementaryShaders 4.7.2) - same issue when enabled.

I have tried removing EMF and JSON entity features etc. - no help. Looks like it is not related to texture packs as well because different mods weapons have the same issue for Epic Fight, including the default one.

Video toolkit mods:
Embeddium: embeddium-0.3.18.1+mc1.19.2
Embeddium++: embeddiumplus-1.19.2-v1.2.13
Oculus: oculus-mc1.19.2-1.6.9

Reproduction Steps

See screens.
Alex mobs: obtain Ghostly pickaxe and stand like on the screen below. Behind the tool, water disappears.
Epic fight: weapon animations' semi-transparent parts also hide water - see screens (the last one with shader).

image
image
image
image

Log File

Nothing wrong in the logs observed, just a visual issue.

@vgrynch
Copy link
Author

vgrynch commented Sep 24, 2024

More screens: It also happens with glass or any modded translucent liquids:
image
image

@vgrynch vgrynch changed the title [1.19.2] Transparency for tools/weapons not rendered correctly over the water [1.19.2] Transparency for tools/weapons not rendered correctly over the tranclucent background Sep 24, 2024
@vgrynch
Copy link
Author

vgrynch commented Sep 24, 2024

And, on top of it: third view, spectator mode: certain things in hands hidden by transparency in spectator mode are displayed as below.
image
(not a big issue though :-) )

@embeddedt
Copy link
Contributor

Are you sure these issues can't also happen without Embeddium installed? From what I can tell, the ghostly pickaxe has similar issues in vanilla:

image

And similar issue with my own head culling water in spectator mode, with vanilla:

image

In general, interactions between translucent entities and translucent terrain are not Embeddium's fault; terrain is rendered at roughly the same time/order it would be in vanilla.

Fabulous is supposed to solve those issues, but mods need to be coded to use it properly, and many mods in older versions just didn't support Fabulous.

@vgrynch
Copy link
Author

vgrynch commented Sep 24, 2024

Any clues if this can be improved? What needs to be changed in texture packs?

@embeddedt
Copy link
Contributor

It's not something that can really be fixed with a resource pack; the mod needs to be designed to use the Fabulous mode feature set properly. And in non-Fabulous mode, some of the cases are not really possible to fix.

@vgrynch
Copy link
Author

vgrynch commented Sep 24, 2024

I don't understand why it cannot be fixed, but I assume that it's not like a simple static bitmap putting over another :-) For me, it looked like some kind of over-culling issue, especially when I saw a few semi-transparent mobs rendered correctly.
Please, close the ticket if you see it's not doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants