Adding support for ECDSA NIST curve SSH keys #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
fakegermano
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
|
as per this: #142 (which I discovered very late I know) I will close this MR, as it seems we do not intend to add the feature for security reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As they are becoming more common in the field, This PR adds support for the use of that type of key for encryption/decryption.
This PR also makes use of the new go 1.21
ecdhpackage that natively implements the key exchange for elliptic curves (supports allX25519andP256,P384andP521).I can also add similar PRs for the
rustandtypescriptimplementations when I have time, but let me know if I have missed something or messed something up, or If I need to add more tests :)