Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support count aggregation function #152

Open
Tracked by #95
Fedomn opened this issue Jan 7, 2023 · 2 comments
Open
Tracked by #95

support count aggregation function #152

Fedomn opened this issue Jan 7, 2023 · 2 comments

Comments

@Fedomn
Copy link
Owner

Fedomn commented Jan 7, 2023

We already have a simple aggregation implementation in V1 https://github.com/Fedomn/sqlrs/blob/main/src/executor/aggregate/simple_agg.rs, that could be a reference.
A different point is that this function need migrate into V2 planner, that could refer to https://github.com/Fedomn/sqlrs/blob/main/src/planner_v2/operator/logical_limit.rs and https://github.com/duckdb/duckdb/blob/main/src/planner/operator/logical_aggregate.cpp

@Fedomn Fedomn mentioned this issue Jan 7, 2023
24 tasks
@caicancai
Copy link

Hi, I want to try it.

@caicancai
Copy link

caicancai commented Nov 15, 2023

Recently, I've been learning about Risinglight, and I have a certain understanding of SQL, and if I want to try it, it may take some time. Because it's a bit difficult for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants