Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install phyx via conda #60

Closed
vmikk opened this issue Apr 21, 2017 · 20 comments
Closed

Install phyx via conda #60

vmikk opened this issue Apr 21, 2017 · 20 comments
Assignees

Comments

@vmikk
Copy link

vmikk commented Apr 21, 2017

Hello!
Thanks a lot for phyx, it looks very promising!
However the installation instructions may seem a bit scary for some users.
Do you plan to distribute phyx via conda (e.g., through bioconda channel)? It's quite popular now and allows to easily handle package dependencies and update the software.

With best regards,
Vladimir

@blackrim
Copy link
Member

That looks cool! Haven't looked into it but will do so and update this issue when it is done. Thanks

@druvus
Copy link

druvus commented Apr 26, 2017

I started to generate a bioconda recipe for phyx but run into some issues. You can find the current PR here: bioconda/bioconda-recipes#4539
I managed to get it building on the linux image that is used by bioconda but forgot something in the recipe. I will try to come back and fix it later during the week but you might have a better understanding of the error.

@nickloman
Copy link

I'd also be keen to see this building on Conda.

@blackrim
Copy link
Member

Cool. I will resurrect this starting with the PR

@druvus
Copy link

druvus commented May 31, 2018

@blackrim I have a working recipe for phyx locally but it needs a rebuild of nlopt using cxx. I opened PR at conda-forge/nlopt-feedstock#12. You are probably more familiar with nlopt to comment issues raised by @jschueller that is maintainer of the nlopt recipe.

@jschueller
Copy link

You dont need to enable cxx. For nlopt what it really does is enable the algorithm that is written in c++, but the api of nlopt remains C. The C++ interface for nlopt exists but is header-only and is not related to the with-cxx option. What you just have to do is tell phyx to link to nlopt instead of nlopt_cxx, here is the relevant phyx configure.ac line:

AC_SEARCH_LIBS([nlopt_urand], [nlopt_cxx], [have_nlopt=yes], [have_nlopt=no], [-lstdc++])

This phyx nlopt detection has to be improved, first look for nlopt, then nlopt_cxx+lstdc++.

@blackrim
Copy link
Member

Thanks @jschueller and @druvus we will have a look at this and hopefully deal with it in the next day or two.

@jfwalker
Copy link
Contributor

Thanks @jschueller and @druvus ! I tried taking a look, is the edit needed as trivial as changing the line to:

AC_SEARCH_LIBS([nlopt_urand], [nlopt], [have_nlopt=yes], [have_nlopt=no], [-lstdc++])

or is there more that needs to be done? Sorry I don't have muct familiarity with conda. Thanks!

@blackrim
Copy link
Member

blackrim commented Jun 1, 2018

@jfwalker thanks but I think I have a better general solution. Pushing in one sec

@blackrim
Copy link
Member

blackrim commented Jun 1, 2018

OK, I believe this has remedied teh situation. No more nlopt_cxx in linking or configure 6372057
@druvus and @jschueller

@druvus
Copy link

druvus commented Jun 1, 2018

@blackrim I have an open PR to build phyx that pass the tests: bioconda/bioconda-recipes#9119

I am currently using the latest commit but would it be possible to get a new tagged release that I could refer to?

@josephwb
Copy link
Member

josephwb commented Jun 1, 2018

We are planning on a minor release update early next week.

@jamie-arcc
Copy link

Is there any update on this? This would be a requisite for FePhyFoFum/PyPHLAWD#27 as well

@josephwb
Copy link
Member

josephwb commented Mar 1, 2019

Sorry this has dragged for so long. Let's get it closed. I have no knowledge of conda. What do you require from us? We should make a new release, as a few bugs have been fixed since the last one. Can you do this @blackrim?

@jamie-arcc
Copy link

bump

@josephwb
Copy link
Member

I don't have the faintest clue what is needed on this from our side (sorry: no experience with conda whatsoever). We do have a recent release here. Is there something else?

@blackrim
Copy link
Member

Back here, but still don't know what we need to do to get this through.

@druvus
Copy link

druvus commented Oct 26, 2020

Finally got back to this and phyx is now available through Bioconda.

@josephwb
Copy link
Member

@druvus Sweet, thanks! So, we can close this?

@druvus
Copy link

druvus commented Oct 27, 2020

Yes, please close it. Upcoming updates will be handled by the Bioconda bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants