Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JacksonJodaDateFormat, JacksonJodaFormatBase, JacksonJodaPeriodFormat needs some constructor Refactoring #85

Closed
joxerTMD opened this issue Jun 28, 2016 · 5 comments

Comments

@joxerTMD
Copy link
Contributor

In order to implement FasterXML/jackson-annotations#95 for Joda module i suggest to add new constructor for these classes that accepts the state of formatter. We need this because the current possibility to add new factory methods is limited by constructor's signature. i.e We can't now have two factory methods of formatter like these: JacksonJodaDateFormat.withSomething(Boolean property).

@joxerTMD
Copy link
Contributor Author

As soon as it's done we can easily implement FasterXML/jackson-annotations#95 like this joxerTMD#1

@cowtowncoder
Copy link
Member

cowtowncoder commented Jun 28, 2016

Sounds reasonable. One thing I need at this point (unless it's already done -- apologies if so) is the Contributor License Agreement, from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

which we need to get just once and is good for all Jackson projects.
Easiest way is usually to print it, fill & sign, scan and email to info at fasterxml dot com.

Looking forward to merging these patches, thank you in advance!

@joxerTMD
Copy link
Contributor Author

the link above returns 404 error for me :(

@cowtowncoder
Copy link
Member

cowtowncoder commented Jun 28, 2016

@joschi ah sorry, wrong link. Updated -- I have a copy of CLA in multiple repose, put wrong link.

@joxerTMD
Copy link
Contributor Author

Done. CLA is signed and sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants