Fix #399; support SmileBufferRecycler via new 2.16 pluggable mechanism #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cowtowncoder is this going to dropped out of 2.16 release? The RC1 has been published and ideally we wouldn't want to sneak in extra changes unless necessary. |
|
@pjfanning I decided to instead drop buffer recycling for Smile altogether, so this PR is not necessary -- but I kept it around as sample in case similar was needed for say Avro. But I can now close this as "won't do". Thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, if we want to continue buffer recycling, here are changes for minimal upgrade.
But based on local performance testing it is not certain recycling is worth it -- will next consider that.