Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize JsonParser.getDoubleValue()/getFloatValue()/getDecimalValue() to avoid String allocation #1284

Closed
cowtowncoder opened this issue Apr 30, 2024 · 0 comments
Closed

Optimize JsonParser.getDoubleValue()/getFloatValue()/getDecimalValue() to avoid String allocation #1284

cowtowncoder opened this issue Apr 30, 2024 · 0 comments
Labels
2.18 Issues planned at earliest for 2.18 performance Issue related to performance problems or enhancements
Milestone
2.18.0

Comments

@cowtowncoder
Copy link
Member

With #1230 done, we can tackle one problem that may have been a regression: the fact that even when following JsonParser methods are used:

  • getDecimalValue()
  • getDoubleValue()
  • getFloatValue()

there will still be a String allocation even if that is not really needed for deferred decoding (like JsonParser.getNumberValueDeferred())
This may be a regression to address other problems with too-early binding of type.
@cowtowncoder cowtowncoder added the 2.18 Issues planned at earliest for 2.18 label Apr 30, 2024
@cowtowncoder cowtowncoder mentioned this issue Apr 30, 2024
Closed
@cowtowncoder cowtowncoder mentioned this issue Jun 9, 2024
Merged
@cowtowncoder cowtowncoder added the performance Issue related to performance problems or enhancements label Jun 25, 2024
cowtowncoder added a commit that referenced this issue Jun 25, 2024
@cowtowncoder
Fix #1284: avoid buffering-as-String for JsonParser.getFloat()/getDou…
cb808a3 
…ble()/getDecimal()
@cowtowncoder cowtowncoder added this to the 2.18.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.18 Issues planned at earliest for 2.18 performance Issue related to performance problems or enhancements
Projects
None yet
Milestone
2.18.0
Development

No branches or pull requests
1 participant
@cowtowncoder