Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS CI entires #500

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update MacOS CI entires #500

merged 1 commit into from
Feb 16, 2024

Conversation

rbx
Copy link
Member

@rbx rbx commented Jan 12, 2024

No description provided.

Copy link

coderabbitai bot commented Jan 12, 2024

Walkthrough

Walkthrough

The changes encompass various aspects of the project. Updates include adjusting macOS configurations for versions 13 and 14 in the Jenkinsfile, introducing testing options in the CMake command in README.md, and updating dependencies like GTest in FairMQDependencies.cmake. Additionally, code changes in files like Common.h, Monitor.cxx, and UnmanagedRegion.h improve memory management and functionality within the project.

Changes

Files Change Summary
Jenkinsfile Updated macOS configurations for versions 13 and 14, added support for apple-clang-15 compiler, adjusted architectures
README.md Added -DBUILD_TESTING=ON option in CMake command, included instructions for building FairMQ dependencies via Spack
cmake/FairMQDependencies.cmake Updated GTest version
examples/region/fairmq-start-ex-region-advanced.sh.in Commented out --rc-segment-size 0 option in SAMPLER configuration
extern/googletest Updated subproject commit hash
fairmq/shmem/Common.h Changed memory allocation strategy from adaptive_pool to node_allocator in RefCountPool declaration
fairmq/shmem/Monitor.cxx Updated PrintShm function to calculate and print used memory alongside size and free memory of rcCountSegment
fairmq/shmem/UnmanagedRegion.h Updated MakeRefCount and RemoveRefCount methods to use allocate_one and deallocate_one methods from fRefCountPool
.devcontainer/devcontainer.json Specified Docker image for development container
.github/workflows/check_metadata.yaml Implemented GitHub Actions workflow for metadata consistency checks

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@rbx rbx changed the base branch from master to dev February 16, 2024 12:03
@rbx
Copy link
Member Author

rbx commented Feb 16, 2024

The CI jobs land as expected on the macs. The failure of some shmem tests on one of the macs is not understood, but is out of scope of this pr.

@rbx rbx merged commit 36b48f5 into dev Feb 16, 2024
5 of 15 checks passed
@rbx rbx deleted the rbx-patch-2 branch February 16, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant