Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Lights (by Tschipcraft) #883

Closed
Madis0 opened this issue Sep 4, 2024 · 3 comments
Closed

Dynamic Lights (by Tschipcraft) #883

Madis0 opened this issue Sep 4, 2024 · 3 comments
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added

Comments

@Madis0
Copy link
Member

Madis0 commented Sep 4, 2024

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/tschipcrafts-dynamic-lights-mod

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/datapack/dynamic-lights

Source/other link

https://github.com/Tschipcraft/dynamiclights

Mod file size

333.98 KiB

License

(any other license)

What it does

A datapack that adds dynamic lights.

Why should it be in the modpack

  • Because LambDynamicLights is not updated yet (but should be soon).
  • In mod form, it's added "cleanly" aka the mod can be disabled and there won't be a "residue" datapack in the worlds
  • It has actual GUI toggles for some features
  • It is only planned as a temporary substitute until LDL is updated

Why shouldn't it be in the modpack

  • No global/per-world toggle (suggested)
  • Only works in singleplayer/LAN
  • Minor issues with redstone

Additional details

I'm well aware there are at least two updated forks of LDL, however the original creator of LDL does not seem to like Fabric forks of it, so it seems to be a better to choose an independent alternative (until LDL is updated), even if inferior.

@Madis0 Madis0 added mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity labels Sep 4, 2024
@Madis0 Madis0 changed the title Dynamic Lights Dynamic Lights (by Tschipcraft) Sep 4, 2024
@magmamir
Copy link

magmamir commented Oct 5, 2024

It's basically a datapack packed as a mod. Because of that, it's server side, and use very broke and incompatible ways to add "dynamic" lights. It should never be added in client-side optimization modpacks, even as a temporary alternative. Imo RyoamicLights is more preferable.

@TheBossMagnus
Copy link
Member

It's basically a datapack packed as a mod. Because of that, it's server side, and use very broke and incompatible ways to add "dynamic" lights. It should never be added in client-side optimization modpacks, even as a temporary alternative. Imo RyoamicLights is more preferable.

RyoamicLights it's a fork of another LambdaDynamicLights, and the original author doesn't appreciate forks of it's work. To avoid drama as now i don't think RyoamicLights is going to get added
also can you provide some examples of broken behavior of this datapack\mod?

@Madis0
Copy link
Member Author

Madis0 commented Oct 8, 2024

While implemented in dev branch, the global toggle, per-player toggle and bugfixes were not released at the time of FO release. Additionally, users were not very interested in this mod and would rather install something else (like shaders) to achieve this feature.

As such, this mod is currently no longer being considered as an alternative.

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@Madis0 Madis0 added the rejected Mods and changes that will not be added label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added
Projects
None yet
Development

No branches or pull requests

3 participants