Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BadOptimizations #787

Open
ItsThosea opened this issue Dec 26, 2023 · 10 comments
Open

BadOptimizations #787

ItsThosea opened this issue Dec 26, 2023 · 10 comments
Labels
feedback/testers wanted Issues that could use more feedback from the users mod New Fabric mod to include

Comments

@ItsThosea
Copy link

ItsThosea commented Dec 26, 2023

CurseForge link

https://curseforge.com/minecraft/mc-mods/badoptimizations

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/badoptimizations/

Source/other link

https://github.com/ItsThosea/BadOpitmizations

Mod file size

~370 KB

License

(any other license)

What it does

  • Cancels lightmap updates if unnecessary
  • Caches current sky color to avoid recalculating it
  • Prevents calling some methods when not needed e.g. debug renderers without debug nodes

Why should it be in the modpack

  • Very simple. Config to disable possibly problematic optimizations.
  • Improves performance. On my own testing with Fabulously Optimized 1.20.4 (I have an RTX 3060 and a 12th gen i7-12700):
    • 1926-1955 FPS without BadOptimizations and without any toasts:
    • 1351-1384 FPS without BadOptimizations and with advancement toasts:
    • 2008-2023 FPS with BadOptimizations and without any toasts:
    • 1414-1458 with BadOptimizations and with advancement toasts:

Why shouldn't it be in the modpack

  • Performance impact is usually small but mostly varies on PC.
  • Might have some hidden compatibility issues.

Additional details

No response
1/3/2024 edit: adjust for 1.5.0
5/10/2024 edit: I can't stand to read the old thing I typed out even tho this got rejected

@ItsThosea ItsThosea added the mod New Fabric mod to include label Dec 26, 2023
@cochcoder
Copy link

When flying around Decked Out 2 in Hermitcraft's Season 9 world, I lose 20-30 FPS on average and have an unstable frame rate with this mod. Is this due to this mod not liking Intel UHD Graphics or some mods in FO? For reference, I am on Fadora Linux using a Intel Core i5-10210U CPU at 1080p.

@Madis0 Madis0 changed the title Mod request: BadOptimizations BadOptimizations Jan 10, 2024
@Madis0 Madis0 added the feedback/testers wanted Issues that could use more feedback from the users label Jan 10, 2024
@cochcoder
Copy link

cochcoder commented Jan 14, 2024

I've done some testing and I can conform that this decrease of performance is due to not liking Linux, I have made a issue on this mod's github page to track any improvments: #20

@cochcoder
Copy link

@Madis0 my issue has been fixed and this mod would make a great addition to this modpack!

@Madis0
Copy link
Member

Madis0 commented Apr 20, 2024

Maybe. Could reevaluate the mod after 1.20.5 is released and in a reasonably stable state.

@ItsThosea
Copy link
Author

Oh.right...1.20.5...🫠

@nyabinary
Copy link

Maybe. Could reevaluate the mod after 1.20.5 is released and in a reasonably stable state.

1.20.6 is out now :3

@Madis0
Copy link
Member

Madis0 commented May 11, 2024

Maybe. Could reevaluate the mod after 1.20.5 is released and in a reasonably stable state.

1.20.6 is out now :3

Well, FO for 1.20.6 is not in a stable or even beta state yet. Still, you are free to test the mod to see if it still has any benefit in FO.

@Niterux
Copy link

Niterux commented Jun 1, 2024

BadOptimizations breaks Polytone (with a Polytone-compatible resource pack equipped) at the moment, I've also had issues with it turning the sky completely grey. For how micro-optimizations-ey these changes seem it feels like it's not worth to add it to the modpack for the instabilities and incompatibilities it causes.

@nyabinary
Copy link

Seems to improve FPS a lil bit for me :p

@girshcatt
Copy link

BadOptimizations breaks Polytone (with a Polytone-compatible resource pack equipped) at the moment, I've also had issues with it turning the sky completely grey. For how micro-optimizations-ey these changes seem it feels like it's not worth to add it to the modpack for the instabilities and incompatibilities it causes.

Is this happening with newest polytone and sodium 0.6.0 beta 2? Give me some resource packs to test please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback/testers wanted Issues that could use more feedback from the users mod New Fabric mod to include
Projects
None yet
Development

No branches or pull requests

6 participants