Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArdaGrass #717

Open
Madis0 opened this issue Sep 9, 2023 · 7 comments
Open

ArdaGrass #717

Madis0 opened this issue Sep 9, 2023 · 7 comments
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added replace Replaces an existing mod

Comments

@Madis0
Copy link
Member

Madis0 commented Sep 9, 2023

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/ardagrass

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/ardagrass

Source/other link

https://github.com/JayemCeekay/ArdaGrass

Mod file size

279.27 KiB

License

(any other license)

What it does

Better Grass from OptiFine, based on Continuity's (hidden?) API

Why should it be in the modpack

Because most people prefer to have the Better Grass from OptiFine that is "fancy", not "fast" (like in the currently bundled resource pack).

Why shouldn't it be in the modpack

  • No toggle for the whole mod
  • No "fast" mode
  • Questionable updating policy (jumped from 1.19.2 to 1.20.1, and that also late), however due to how this works, it is usually cross-compatible anyway

Additional details

Because this uses Continuity as a dependency, it should break less with Minecraft updates, provided Continuity itself is up to date.

@Madis0 Madis0 added mod New Fabric mod to include on hold Mods that are waiting for something before inclusion parity Mods that add Optifine, Bedrock or Forge parity replace Replaces an existing mod labels Sep 9, 2023
@zumbiepig
Copy link

I think this would be good. I have been using Quilt instead of Fabric for LamdaBetterGrass, and either Indium or EBE is buggy in Quilt, so this addition would be very good.

@Madis0
Copy link
Member Author

Madis0 commented Sep 24, 2023

I really want to add this on 1.20.2 but for that I hope that the dev (besides updating the mod) will consider a toggle at least. Wouldn't want to force better grass on everyone without an opt-out.

@zumbiepig
Copy link

Good point.

@sirenuf

This comment was marked as off-topic.

@Madis0

This comment was marked as off-topic.

@PepperCode1
Copy link

The mod is not "based on Continuity's (hidden?) API". It uses the SpriteCalculator class, which is strictly an implementation class that can change or be removed at any time without warning.

@Madis0
Copy link
Member Author

Madis0 commented Oct 29, 2024

Outdated for a while, plus other described issues in OP. #845 seems more likely to get added.

@Madis0 Madis0 added rejected Mods and changes that will not be added and removed on hold Mods that are waiting for something before inclusion labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include parity Mods that add Optifine, Bedrock or Forge parity rejected Mods and changes that will not be added replace Replaces an existing mod
Projects
None yet
Development

No branches or pull requests

4 participants