Option to add comments in frr.conf / vtysh

[vecinohk]

Hi, I have an idea or suggestion to add a note or comment in the configuration.

For example, if I add a comment via vi / nano directly in the frr.conf file and then do some editing via vtysh and perform a save, I will lose all comments.

That's why I'm wondering if it would be possible to officially add comments in future versions.

To give you an idea of how that would help me for example:

!
ipv6 route 2a01:1**:****::/44 blackhole
ipv6 route 2a01:1**:****:100::/56 2a01:1**:****::100 vlan203 comment: "ID: 123 Mr. XXX"
ipv6 route 2a01:1**:****:200::/56 2a01:1**:****::200 vlan203 commnet: "ID: 124 Mr. XXX"
ipv6 route 2a01:1**:****:300::/56 2a01:1**:****::300 vlan203 commnet: "ID: 125 Mr. XXX"
...
...
!

That's how I would see which client owns which route.

Thank you 👍

[ton31337]

Are you talking about something similar to #12141? Or do you mean printing the comments in any configuration context?

[vecinohk]

Yes something like Cisco has as someone wrote in #12141 . The point is that when you have a configuration with many clients (many static routes, so it is not clear which belongs to whom).

Otherwise the idea of commenting anything in the configuration is not bad either. I know people who deliberately don't use vtysh to save their config, but write everything manually in frr.conf so they don't lose all the comets they have there.

[donaldsharp]

This is a decent idea. Someone would need to figure out how to implement this. I imagine it would be quite hairy giving how frr currently builds a unified config. This probably can be revisisted and be much much easier once all daemons are converted to yang.