Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot calibrate ETB/TPS without accel pedal #433

Open
nmschulte opened this issue May 25, 2024 · 0 comments
Open

cannot calibrate ETB/TPS without accel pedal #433

nmschulte opened this issue May 25, 2024 · 0 comments

Comments

@nmschulte
Copy link
Contributor

nmschulte commented May 25, 2024 •
edited
Loading

EtbController won't return successful init unless there's an accel pedal present: https://github.com/FOME-Tech/fome-fw/blob/master/firmware/controllers/actuators/electronic_throttle.cpp#L165

This seems unnecessary, for both TPS auto-calibration and PID autotune.

Perhaps init should remove this check? Unsure how ETB pedal target (m_pedalMap) would behave if no channels configured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmschulte