Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EngineModule has no sound initialization interface #422

Open
nmschulte opened this issue May 4, 2024 · 0 comments
Open

EngineModule has no sound initialization interface #422

nmschulte opened this issue May 4, 2024 · 0 comments
Labels
💰 tech debt 💰 Not causing an active problem, but good to fix.

Comments

@nmschulte
Copy link
Contributor

EngineModules like BoostController and others implement initialization in various ways: particularly, not via their constructor or any EngineModule abstraction. This leads to issues, like what #419 resolves, in that various modules/controllers wind up not being initialized on reset.

Many possible solutions; one proposed by @mck1117 is to make onConfigurationChange invoked on ECU reset.
@nmschulte nmschulte added the 💰 tech debt 💰 Not causing an active problem, but good to fix. label May 4, 2024
@nmschulte nmschulte mentioned this issue May 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💰 tech debt 💰 Not causing an active problem, but good to fix.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmschulte