-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
m_maximumretard broken, resulting in knock controller not working. Related to Closed Loop Fueling? #417
Comments
see also #246 |
is this rusefi/rusefi#6370? |
@rusefillc Let me go give this a try, ill report back |
With zero's in the first row, it did not pull timing, and m_maximumretard was Zero when the car was off, and remained zero when the car was on and didnt change regardless of RPM or MAP It did not make it so that upon ecu power cycle that the m_maximumretard would be anything but constant zero. changing the bottom cells back to Non zeroes, and doing the step of Closed loop fuel control off then on resulted in the knock controller responding. My Max knock table isnt TPS vs rpm its MAP vs RPM |
column and row definition were swapped w/re: value lookup fixes FOME-Tech#246, FOME-Tech#417
Not related to closed loop fueling, related to any config burn. If you do a burn, then the knock retard max table would actually work. |
Proteus f7 BMM ecu for Mazda Miata NA6
When setting up the Max knock retard table with an array of values ranging from 2 through 10. The variable m_maximumretard does not correlate properly, I assumed if i set up a table of RPM, MAP, Knock: max retard i would see a table that represents my tune table. That was not the case. Furthermore, It made me realize it was not pulling timing when knock count incremented.
This is what I have found so far
- m_maximumretard is a constant 0 regardless of Max Knock Retard Table
- m_maximumretard changes from 0 to 2 regardless of Max Knock Retard Table
- Upon power cycle, m_maximumretard value stayed 2
- m_maximumretard starts at 0, goes to 2.
- Started the car, m_maximumretard goes to 8, stays at 8 constant regardless of Max Knock Retard Table
- Drove around, took a log, both Closed loop fuel control and Knock Controller work as Expected. Pulling timing, and fuel trimming.
- When I turned the car off, the m_maximumretard stayed constant at 8. When I power cycled ECU, value returned to 0.
The text was updated successfully, but these errors were encountered: