New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative timing is not displayed correctly in two stroke mode #396

Open

rusefillc opened this issue Mar 20, 2024 · 1 comment

Contributor

rusefillc commented Mar 20, 2024

	// that's weird logic. also seems broken for two stroke?
	engine->outputChannels.ignitionAdvance = (float)(advance > FOUR_STROKE_CYCLE_DURATION / 2 ? advance - FOUR_STROKE_CYCLE_DURATION : advance);

As the code comment says - it's broken for two stroke. See rusefi/rusefi@5d46bb1 which includes unit test

The text was updated successfully, but these errors were encountered:

Contributor Author

rusefillc commented Mar 20, 2024

See also #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment