Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levante/wiso #347

Open
wants to merge 5 commits into
base: wiso
Choose a base branch
from
Open

Levante/wiso #347

wants to merge 5 commits into from

Conversation

mandresm
Copy link
Collaborator

@mandresm mandresm commented Jun 3, 2022

Cherry picks from #338 with the necessary conflict resolution.

@xshi-awi

koldunovn and others added 5 commits June 3, 2022 15:03
(cherry picked from commit c303398)
(cherry picked from commit 0fe2dcb)
(cherry picked from commit 99095a9)
(cherry picked from commit 7c4cc2b)
(cherry picked from commit bce8620)
(cherry picked from commit 49d98c9)
(cherry picked from commit 84c35c9)
(cherry picked from commit d96082d)
- set special compile flags for intel compiler on levante for fesom and parms

(cherry picked from commit a1b36a2)
(cherry picked from commit 559d8c6)
@mandresm mandresm requested a review from koldunovn June 3, 2022 13:07
@mandresm
Copy link
Collaborator Author

mandresm commented Jun 3, 2022

Hi @koldunovn, these changes are for the development branch of wiso, as long as @xshi-awi is okay with the changes then it can be merged. Unfortunately, for some reason, I cannot request for her revision in GitHub so I added you as reviewer.

@koldunovn
Copy link
Member

@mandresm The checks are failing, is it ok with you?

@mandresm
Copy link
Collaborator Author

mandresm commented Jun 3, 2022

They are also failing in the wiso branch, in the last commit. I think it is because the wiso devs did not pull the ubuntu environment. In any case, whether including the changes for this branch to run automatic testing or not, is a decision for @xshi-awi and or @mwerner-awi to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants