Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address bar parameter support for new element dialog #83

Open
CSchmitz81 opened this issue Sep 4, 2018 · 4 comments
Open

Add address bar parameter support for new element dialog #83

CSchmitz81 opened this issue Sep 4, 2018 · 4 comments

Comments

@CSchmitz81
Copy link
Member

CSchmitz81 commented Sep 4, 2018

The element dialog and user dialog both update the address bar with custom parameters, but the new element dialog doesn't support this yet. This gives a strange experience for uses pressing back and when opening a page to a specific address. The address bar should track the parent element ID as "e" and type ID as "t" (both optional). The "d" parameter should be set to "new" to indicate the type of dialog. If the type is specified, the top bar color should be set accordingly in the new element dialog. This should use the same implementation patterns in ctree-dialogs.html as the other dialog types. This should behave correctly if the browser is refreshed.

@CSchmitz81
Copy link
Member Author

@carloe1 I saw the branch you added for this. Does that mean you plan to continue working on it during the hackathon this weekend?

@CSchmitz81
Copy link
Member Author

@carloe1 are you still working on this or should I release it for someone else to pick up?

@CSchmitz81
Copy link
Member Author

Unassigning due to lack of progress. Check branch #83-adding-parameters-to-new-dialog for work which can be used before doing additional work.

@CSchmitz81
Copy link
Member Author

Review branch #83-adding-parameters-to-new-dialog-url to see if it can be used as a starting point for finishing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants