Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Page Features #60

Open
CSchmitz81 opened this issue Jul 7, 2018 · 9 comments · Fixed by #132
Open

Landing Page Features #60

CSchmitz81 opened this issue Jul 7, 2018 · 9 comments · Fixed by #132
Labels
Add good first issue Good issue for developers new to the project. Level: Easy Team: Landing Page
Milestone

Comments

@CSchmitz81
Copy link
Member

CSchmitz81 commented Jul 7, 2018

Implement the features screen of the landing page. This should be a grid of features, including an icon, title, and brief description to the right of the icon. This grid should automatically adjust to fit the width of the screen, and adjust the number of items per row if there's not enough room to fit the full item. For small screens (400px or less) the title and description should be move under the icon. The icons and text should be taken from the comp.

Please base your changes on the develop-landing-page branch.

See the comps for desktop and mobile for reference.

@CSchmitz81 CSchmitz81 added this to the Alpha milestone Jul 7, 2018
@CSchmitz81 CSchmitz81 added the good first issue Good issue for developers new to the project. label Feb 2, 2019
@CSchmitz81
Copy link
Member Author

@begunfx please only move issues to in progress when they're assigned to you, and try to only assign one issue at a time to yourself unless there's a lot of overlap

@nclairesays nclairesays self-assigned this Apr 6, 2019
@nclairesays nclairesays removed their assignment Apr 17, 2019
@jubaldo jubaldo self-assigned this May 9, 2019
@CSchmitz81 CSchmitz81 assigned begunfx and unassigned jubaldo May 11, 2019
@CSchmitz81
Copy link
Member Author

#109 was merged, but didn't include enough to consider this ticket complete. It still needs the placeholder items (ripping the images from the wires would be fine, or any other placeholders). As shown in the comps, these should adjust how many items show per row based on the screen width, down to a single item per row on mobile.

@CSchmitz81
Copy link
Member Author

@begunfx I'm pulling you off this for now since it's been a while. If you still plan to work on this in the near future please assign it back to yourself.

@rajm1 rajm1 self-assigned this Oct 5, 2019
@CSchmitz81
Copy link
Member Author

@rajm1 any progress or branch you can share for this?

@rajm1
Copy link
Collaborator

rajm1 commented Oct 16, 2019 via email

@CSchmitz81
Copy link
Member Author

@rajm1 I couldn't find your changes. Did you push them out yet? If so, to what branch?

@nicoleiocana nicoleiocana self-assigned this Nov 25, 2019
@CSchmitz81
Copy link
Member Author

removing @rajm1 due to a lack of feedback, assigning to @nicoleiocana

CSchmitz81 added a commit that referenced this issue May 21, 2020
@CSchmitz81
Copy link
Member Author

Merged #132 because it was close to matching the comp and hadn't been updated in a while, but there's still some minor improvements needed to completely match the comps.

@CSchmitz81
Copy link
Member Author

@nicoleiocana Unassigning from you because there hasn't been much work on this lately, but feel free to assign it to yourself again if you want to finish off the comp matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add good first issue Good issue for developers new to the project. Level: Easy Team: Landing Page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants