Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling cursor into view #502

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

Skalakid
Copy link
Collaborator

Details

This PR fixes the logic behind scrolling input's content into view while typing and pasting text

Related Issues

Expensify/App#45885

Manual Tests

  1. Open the example app
  2. Limit the height of the input so it's scrollable
  3. Put the cursor in the middle of the input
  4. Blur it
  5. Scroll the content to the top or bottom
  6. Click Focus button
  7. Verify if the content was scrolled into view

Pasting long text:

  1. Paste the really long text into empty input
  2. Verify if the content was scrolled into view and if the cursor at the end of pasted text is visible

Linked PRs

@Skalakid Skalakid marked this pull request as ready for review September 20, 2024 13:17
@Skalakid Skalakid self-assigned this Sep 20, 2024
@Skalakid Skalakid merged commit a8d1ff2 into main Sep 25, 2024
5 checks passed
@Skalakid Skalakid deleted the @Skalakid/fix-scrolling-into-view branch September 25, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants