Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline images follow ups #497

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Add inline images follow ups #497

merged 4 commits into from
Sep 17, 2024

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Sep 17, 2024 •
edited
Loading

Details

This PR:

  • fixes broken image icon position when URL is wron
  • fixes problem with too frequent structure rerenders when image was added
  • adds debounce when image URL is being changed
  • changes default image in example app

Related Issues

Expensify/App#49250

Manual Tests

Linked PRs

BartoszGrajdek
BartoszGrajdek approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Skalakid Skalakid merged commit 1b2777e into main Sep 17, 2024
5 checks passed
@Skalakid Skalakid deleted the @Skalakid/inline-images-follow-ups branch September 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartoszGrajdek BartoszGrajdek BartoszGrajdek approved these changes

@tomekzaw tomekzaw Awaiting requested review from tomekzaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skalakid @BartoszGrajdek