Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CMakeLists.txt #492

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Cleanup CMakeLists.txt #492

merged 1 commit into from
Sep 16, 2024

Conversation

tomekzaw
Copy link
Collaborator

@tomekzaw tomekzaw commented Sep 16, 2024 •
edited
Loading

Details

  • Moved common prefabs outside of conditionals
  • Removed unused prefabs and shared libraries (e.g. android, log, ReactAndroid::mapbufferjni)
  • Added missing find_package for fbjni prefab
  • Added missing ReactAndroid:: prefix in prefabs

Related Issues

GH_LINK

Manual Tests

Linked PRs

j-piasecki
j-piasecki approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, there was a lot of unnecessary libs there. Sorry 😅.

@tomekzaw
Copy link
Collaborator Author

tomekzaw commented Sep 16, 2024 •
edited
Loading

No worries, thanks for review! They all are gonna be replaced with ReactAndroid::reactnative so we'd remove this code pretty soon anyway.

@tomekzaw tomekzaw merged commit 227ee74 into main Sep 16, 2024
5 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/cleanup-cmakelists branch September 16, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomekzaw @j-piasecki