Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align single line text span #486

Merged

Conversation

VickyStash
Copy link
Contributor

Details

This PR aligns text inside the span on the web. During switching one of the inputs inside the E/App to MarkdownInput the issue with text alignment was defined -> the text alignment inside the usual and markdown inputs with the same styling looked different.
This PR updates the text alignment in span to fix the issue.

Usual input Markdown input without the alignment Current PR - with alignment
image image image

Related Issues

GH_LINK

Manual Tests

You can test the updates over this PR: Expensify/App#47547

  1. Login the app.
  2. Open Profile -> Display name.
  3. Verify the text alignment in inputs.

Linked PRs

N/A

@VickyStash VickyStash marked this pull request as ready for review September 13, 2024 14:28
@VickyStash
Copy link
Contributor Author

@Skalakid @tomekzaw Please, take a look

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@tomekzaw tomekzaw merged commit 17888cf into Expensify:main Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants