Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removeSpan crash on Android #469

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Fix removeSpan crash on Android #469

merged 11 commits into from
Sep 12, 2024

Commits on Sep 3, 2024

  1. Fix android crash when modifying the markdown through selection

    @wildan-m
    wildan-m committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c974bdc View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'Expensify:main' into wildan/fix/46908-delete-markdown-c… 

    …rash
    @wildan-m
    wildan-m authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    15652dc View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge branch 'main' of https://github.com/wildan-m/react-native-live-… 

    …markdown into wildan/fix/46908-delete-markdown-crash
    @wildan-m
    wildan-m committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0dfd7b9 View commit details
    Browse the repository at this point in the history

  2. compare with prev text value to avoid multiple applyMarkdownFormattin… 

    …g calls
    @wildan-m
    wildan-m committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c176a5e View commit details
    Browse the repository at this point in the history

  3. store mPreviousEditable as string to minimize conversion

    @wildan-m
    wildan-m committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ade58bc View commit details
    Browse the repository at this point in the history

  4. Update android/src/main/java/com/expensify/livemarkdown/MarkdownTextW… 

    …atcher.java

Co-authored-by: Tomek Zawadzki <[email protected]>
    @wildan-m @tomekzaw
    wildan-m and tomekzaw authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    88baac1 View commit details
    Browse the repository at this point in the history

  5. refactor

    @wildan-m
    wildan-m committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    24a7e7f View commit details
    Browse the repository at this point in the history

  6. revert unnecessary change

    @wildan-m
    wildan-m committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c6186b4 View commit details
    Browse the repository at this point in the history

  7. revert unnecessary change

    @wildan-m
    wildan-m committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f160781 View commit details
    Browse the repository at this point in the history

  8. Update android/src/main/java/com/expensify/livemarkdown/MarkdownTextW… 

    …atcher.java

Co-authored-by: Tomek Zawadzki <[email protected]>
    @wildan-m @tomekzaw
    wildan-m and tomekzaw authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1864419 View commit details
    Browse the repository at this point in the history

  9. remove optimization

    @wildan-m
    wildan-m committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    feb5cd7 View commit details
    Browse the repository at this point in the history