Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow historyIndex to be updated when pasting twice #280

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

BartoszGrajdek
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek commented Apr 10, 2024

Details

Fix for a bug where user was unable to undo text that was pasted and undone before

Related Issues

GH_LINK

Manual Tests

  1. Paste some text
  2. CMD + Z
  3. Paste the same text once again
  4. CMD + Z - this wasn't working before

Linked PRs

#266

@BartoszGrajdek BartoszGrajdek changed the title feat: refine add & undo for InputHistory Allow historyIndex to be updated when pasting twice Apr 11, 2024
@BartoszGrajdek BartoszGrajdek marked this pull request as ready for review April 11, 2024 08:25
Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦹‍♂️

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but haven't tested it

@tomekzaw tomekzaw merged commit c2993d6 into main Apr 12, 2024
4 checks passed
@tomekzaw tomekzaw deleted the @BartoszGrajdek/fix-repeated-input-history branch April 12, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants