Fix missing headers on iOS when using static linkage #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
force-pushed
the
@tomekzaw/fix-missing-headers-ios-linkage-static
branch
from
6a3bf24
to
12c0957
Compare
tomekzaw
commented
Feb 5, 2024
| @@ -1,15 +1,15 @@ | |||
| #import <React/RCTUITextField.h> | |||
| #import <react/debug/react_native_assert.h> | |||
| #import "react_native_assert.h" | |||
There was a problem hiding this comment.
For some reason #import <react/debug/react_native_assert.h> also does not work, changed to #import "react_native_assert.h".
tomekzaw
commented
Feb 5, 2024
|
|
||
| #ifdef RCT_NEW_ARCH_ENABLED | ||
| #import <React/RCTConversions.h> | ||
| #else | ||
| #import <React-Core/React/RCTConvert.h> | ||
| #import <React/RCTConvert.h> |
There was a problem hiding this comment.
React_Core doesn't work
AndrewGable
approved these changes
Feb 5, 2024
robertKozik
approved these changes
Feb 5, 2024
thienlnam
approved these changes
Feb 5, 2024
AndrewGable
deleted the
@tomekzaw/fix-missing-headers-ios-linkage-static
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes the following compile errors related to missing headers on iOS when static linkage is enabled (reported by @staszekscp):
As it turns out, when static linkage is enabled, all
-in header paths are replaced with_. The following change resolves the problem:However, we would need to add macro conditionals to support both paths like Expo does here:
https://github.com/expo/expo/blob/294399de1e40f628b3ffdd5176eb181690d870ce/packages/expo-dev-menu/ios/ReactNativeCompatibles/ReactNative/DevClientAppDelegate.mm#L5-L10
The simpler solution is to eliminate all
-from podspec name by renaming it fromreact-native-live-markdowntoRNLiveMarkdown(similarly toRNReanimated,RNGestureHandlerand others).Related Issues
GH_LINK
Manual Tests
Linked PRs