Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate leaf text nodes on web #239

Closed
tomekzaw opened this issue Mar 20, 2024 · 3 comments
Closed

Eliminate leaf text nodes on web #239

tomekzaw opened this issue Mar 20, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tomekzaw
Copy link
Collaborator

tomekzaw commented Mar 20, 2024

Current Behavior

Currently we treat text that is not wrapped with markdown as a text node and line breaks as \n, this makes the library prone to errors related with scrolling & cursor movement.

Expected Behavior

  1. All leaf text nodes should be wrapped by an individual tag
  2. We should use <br> instead of \n
  3. (optional) Each new paragraph / line of text should be wrapped with <p> tag
@tomekzaw
Copy link
Collaborator Author

@Skalakid Is this issue still relevant?

@BartoszGrajdek
Copy link
Collaborator

It's finished 👍🏻

@tomekzaw
Copy link
Collaborator Author

Cool, closing then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants