Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show on the K2 dashboard when someone else is the issue owner #187

Merged
merged 4 commits into from
May 1, 2024
Merged

Show on the K2 dashboard when someone else is the issue owner #187

merged 4 commits into from
May 1, 2024

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Apr 25, 2024

Fixes https://github.com/Expensify/Expensify/issues/390841

Tests

  1. Have a test issue like https://github.com/Expensify/Expensify/issues/390830
  2. Assign it only to yourself
  3. Verify you can set yourself as the code owner and you can toggle it on and off
  4. Assign the issue to one more person and make them the code owner
  5. Refresh your K2 dashboard and verify the issue is shown with an empty star
  6. Check the filter to hide "Owned by Someone Else"
  7. Verify that the issues with an empty star are no longer shown

image

image

@tgolen tgolen requested a review from a team April 25, 2024 17:32
@tgolen tgolen self-assigned this Apr 25, 2024
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team April 25, 2024 17:33
@cristipaval
Copy link
Contributor

This is the first K2 PR I've seen. I'll review it next week, as I have no setup to test it now and I am pushing on VIP work today

@tgolen
Copy link
Contributor Author

tgolen commented May 1, 2024

@cristipaval bump for review please.

@cristipaval cristipaval merged commit 69926cf into main May 1, 2024
4 checks passed
@cristipaval cristipaval deleted the tgolen-improve-starred branch May 1, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristipaval cristipaval cristipaval approved these changes

Assignees

@tgolen tgolen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgolen @cristipaval