Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node and npm versions for QSP #182

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Update node and npm versions for QSP #182

merged 2 commits into from
Jan 15, 2024

Conversation

NikkiWines
Copy link
Contributor

Upgrades node to v20.10.0 and npm to v10.2.3

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/358623

Tested this as my local version of k2

@NikkiWines NikkiWines self-assigned this Jan 12, 2024
@NikkiWines NikkiWines changed the title Update node version to 20.10.0 and npm to 10.2.3 Update node and npm versions for QSP Jan 12, 2024
@NikkiWines NikkiWines changed the title Update node and npm versions for QSP [HOLD] Update node and npm versions for QSP Jan 12, 2024
@fukawi2 fukawi2 changed the title [HOLD] Update node and npm versions for QSP Update node and npm versions for QSP Jan 14, 2024
@fukawi2
Copy link
Contributor

fukawi2 commented Jan 14, 2024

Looks like you also need to update this line too @NikkiWines https://github.com/Expensify/k2-extension/blob/1476915cb1e89d9b4717b49cf0fb500362636eb5/.github/workflows/lint.yml#L25C25-L25C25

@fukawi2 fukawi2 self-requested a review January 14, 2024 23:14
@NikkiWines
Copy link
Contributor Author

Oops, sorry about that. Updated @fukawi2!

@fukawi2 fukawi2 merged commit cd5f1a1 into main Jan 15, 2024
3 checks passed
@fukawi2 fukawi2 deleted the nikki-update-node branch January 15, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants