Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data-code-raw for pre blocks #705

Conversation

BartoszGrajdek
Copy link
Contributor

@BartoszGrajdek BartoszGrajdek commented May 24, 2024

After we changed the syntax for codeFence we found a bug where it was possible to add a room mention inside of it. This PR prevents that from happening & removes data-code-raw which is not necessary after all of our changes.

Fixed Issues

$ GH_LINK

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    All of the tests that were edited
  2. What tests did you perform that validates your changed worked?
    I checked if there were any new errors inside of react-native-live-markdown library and inside of E/App (which was not necessary since these changes don't affect it).

QA

  1. What does QA need to do to validate your changes?
    Don't know actually, this is a clean-up rather than a feature
  2. What areas to they need to test for regressions?
    I've added some regression test to check for room mentions inside of codeFence
image

@BartoszGrajdek BartoszGrajdek changed the title feat: remove data-code-raw Remove data-code-raw for pre blocks May 24, 2024
@BartoszGrajdek BartoszGrajdek marked this pull request as ready for review June 5, 2024 10:32
@BartoszGrajdek BartoszGrajdek requested a review from a team as a code owner June 5, 2024 10:32
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team June 5, 2024 10:32
@BartoszGrajdek
Copy link
Contributor Author

cc @dangrous since he was responsible for reviewing the previous PR and has context on what's happening here 👀

Copy link
Contributor

@youssef-lr youssef-lr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youssef-lr youssef-lr merged commit 1ee6047 into Expensify:main Jun 5, 2024
6 checks passed
Copy link

github-actions bot commented Jun 5, 2024

🚀Published to npm in v2.0.9

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Do we have a test in there that checks that urls inside

s work properly? Other than that I think this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants